----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/#review136346 -----------------------------------------------------------
src/master/http.cpp (line 678) <https://reviews.apache.org/r/48116/#comment201361> Depending on what the final return type ends up being (for `_updateMaintenanceSchedule`), is this missing a `.then(serializer);` ? - Joseph Wu On June 5, 2016, 11 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48116/ > ----------------------------------------------------------- > > (Updated June 5, 2016, 11 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5505 > https://issues.apache.org/jira/browse/MESOS-5505 > > > Repository: mesos > > > Description > ------- > > Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API. > > > Diffs > ----- > > src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 > src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 > src/master/http.cpp 4fbf5638fb9ae8e7b28c21529d15735e46a85ffb > src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 > > Diff: https://reviews.apache.org/r/48116/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >