> On June 6, 2016, 9:06 p.m., Joseph Wu wrote: > > src/master/http.cpp, line 678 > > <https://reviews.apache.org/r/48116/diff/1/?file=1406733#file1406733line678> > > > > Depending on what the final return type ends up being (for > > `_updateMaintenanceSchedule`), is this missing a `.then(serializer);` ?
Not need, because we return a empty `OK` result. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/#review136346 ----------------------------------------------------------- On June 9, 2016, 5:31 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48116/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 5:31 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5505 > https://issues.apache.org/jira/browse/MESOS-5505 > > > Repository: mesos > > > Description > ------- > > Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API. > > > Diffs > ----- > > src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 > src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 > src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c > src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb > > Diff: https://reviews.apache.org/r/48116/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
