> On June 7, 2016, 2:19 p.m., Vinod Kone wrote: > > src/examples/balloon_framework.cpp, lines 73-76 > > <https://reviews.apache.org/r/45604/diff/5/?file=1407783#file1407783line73> > > > > see above. don't need this.
Note: This is fixed, but currently does not print the correct validation message. When `--task_memory_usage_limit` is not specified, the error is `Please use a --task_memory_usage_limit greater than 64 MB` rather than `Flag 'task_memory_usage_limit' is required, but it was not provided`. Chatted with Greg offline, and he'll fix the flag validation code separately: https://github.com/apache/mesos/blob/56ebc7eb0b04c7c79656ad74c347b0a2e4debc99/3rdparty/stout/include/stout/flags/flags.hpp#L1005-L1009 - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45604/#review136542 ----------------------------------------------------------- On June 9, 2016, 4:48 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45604/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 4:48 p.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and > Vinod Kone. > > > Bugs: MESOS-5174 > https://issues.apache.org/jira/browse/MESOS-5174 > > > Repository: mesos > > > Description > ------- > > This gives the example `balloon-framework` enough options to run > outside of the build environment: > > * Adds an option for restricting the number of resources per task > (otherwise, it will eat up an entire node). > * Adds an option for persisting the framework and launching one task > after another. > * Adds filters for declined offers. > > > Diffs > ----- > > src/examples/balloon_framework.cpp 739fb504e93154bf032b4c621151fa3c99b60037 > src/tests/balloon_framework_test.sh > a242f6cb9ca1850e5fef90e0938f41044bdaddbf > > Diff: https://reviews.apache.org/r/45604/diff/ > > > Testing > ------- > > ``` > make check > > sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework" > ``` > > > Thanks, > > Joseph Wu > >
