----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45472/#review137146 -----------------------------------------------------------
I think in `NetClsSubsystem`, you still need a stub for the `update()` method, please check the following code: https://github.com/apache/mesos/blob/0.28.2/src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp#L461:L465 If we do not have the stub for the `update()` method, then the TODO in the above code will be lost. - Qian Zhang On April 16, 2016, 6:22 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45472/ > ----------------------------------------------------------- > > (Updated April 16, 2016, 6:22 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, Guangya Liu, Ian > Downes, Jie Yu, and Kevin Klues. > > > Bugs: MESOS-5046 > https://issues.apache.org/jira/browse/MESOS-5046 > > > Repository: mesos > > > Description > ------- > > Add `NetClsSubsystem` for cgroups unified isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/45472/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >