> On June 12, 2016, 1:48 a.m., Qian Zhang wrote: > > I think in `NetClsSubsystem`, you still need a stub for the `update()` > > method, please check the following code: > > https://github.com/apache/mesos/blob/0.28.2/src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp#L461:L465 > > > > If we do not have the stub for the `update()` method, then the TODO in the > > above code will be lost.
Good catch! - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45472/#review137146 ----------------------------------------------------------- On June 19, 2016, 4:39 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45472/ > ----------------------------------------------------------- > > (Updated June 19, 2016, 4:39 p.m.) > > > Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, > Kevin Klues, and Qian Zhang. > > > Bugs: MESOS-5046 > https://issues.apache.org/jira/browse/MESOS-5046 > > > Repository: mesos > > > Description > ------- > > Add `NetClsSubsystem` for cgroups unified isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/45472/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >