----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review137281 -----------------------------------------------------------
src/common/values.cpp (lines 399 - 410) <https://reviews.apache.org/r/48593/#comment202442> Thanks for digging into this issue further. Please do read my response on your e-mail thread for further context. This patch looks like it fixes a particular bottleneck by converting to intervalset inline. I understand why you did this, as my e-mail outlines that changing the stored data-type is more complicated. I can see how this improves performance; however, is the resource validation of ranges also not a problem? Your benchmarks are specific to this operation. Have you tried this patch your example 10K task / 20 node cluster to identify if the validation is still a bottleneck? If we run all the benchmarks in the test suite, are all of them positively impacted? Or are some negatively? If this is purely a win, then we can consider this approach as a temporary fix assuming the following: - Simple patch (yes! :-D ) - A JIRA to follow up with changing the stored data-type so we don't treat this as a permanent solution - Joris Van Remoortere On June 12, 2016, 8:03 a.m., Yanyan Hu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48593/ > ----------------------------------------------------------- > > (Updated June 12, 2016, 8:03 a.m.) > > > Review request for mesos and Guangya Liu. > > > Bugs: MESOS-5425 > https://issues.apache.org/jira/browse/MESOS-5425 > > > Repository: mesos > > > Description > ------- > > This patch reimplement Ranges subtraction using > IntervalSet data type: Ranges values will be > converted to IntervalSet values for subtraction > and the result will be converted back to Ranges > after subtraction is done. This change is for > fixing jira MESOS-5425. > > > Diffs > ----- > > src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b > > Diff: https://reviews.apache.org/r/48593/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yanyan Hu > >
