> On June 13, 2016, 8:18 p.m., Anand Mazumdar wrote: > > Can we name the unversioned proto file as just `agent.proto`? It would be > > good to not introduce the `Slave` terminology going forward :-) > > Vinod Kone wrote: > also the package name, class name, namespace etc.
Awesome! Let me rename. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48587/#review137370 ----------------------------------------------------------- On June 12, 2016, 6:01 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48587/ > ----------------------------------------------------------- > > (Updated June 12, 2016, 6:01 p.m.) > > > Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone. > > > Bugs: MESOS-5593 > https://issues.apache.org/jira/browse/MESOS-5593 > > > Repository: mesos > > > Description > ------- > > Added unversioned protos for agent API. > > > Diffs > ----- > > include/mesos/slave/slave.hpp PRE-CREATION > include/mesos/slave/slave.proto PRE-CREATION > src/Makefile.am b656702d918e747cbd4b3d8f2c4257f61c83b385 > > Diff: https://reviews.apache.org/r/48587/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
