-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48938/#review138642
-----------------------------------------------------------




src/tests/api_tests.cpp (line 765)
<https://reviews.apache.org/r/48938/#comment203843>

    Insert a blank line below, refer to 
https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#empty-lines



src/tests/api_tests.cpp (line 879)
<https://reviews.apache.org/r/48938/#comment203840>

    I think need
    ```
    AWAIT_READY(v1DestroyVolumesResponse) here
    ```
    ?


- haosdent huang


On June 20, 2016, 1:54 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48938/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5502
>     https://issues.apache.org/jira/browse/MESOS-5502
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test case `MasterAPITest.CreateAndDetroyVolumes`.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 7ce62d92a87f4885d8c4faab542c49d5bfb251d3 
>   src/internal/evolve.cpp 67c550342c06acdfcd0ed5cbe860ad29e41e6846 
>   src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf 
> 
> Diff: https://reviews.apache.org/r/48938/diff/
> 
> 
> Testing
> -------
> 
> "make check" on ubuntu 14.04 64bit with gcc.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Reply via email to