----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48455/#review138926 -----------------------------------------------------------
I did a scan of the file and left comments for missing includes below. src/master/allocator/sorter/drf/sorter.cpp (lines 28 - 29) <https://reviews.apache.org/r/48455/#comment204118> Can you add includes for std::set and std::string? src/master/allocator/sorter/drf/sorter.cpp (lines 124 - 125) <https://reviews.apache.org/r/48455/#comment204120> Includes for SlaveID and Resources? src/master/allocator/sorter/drf/sorter.cpp (line 392) <https://reviews.apache.org/r/48455/#comment204123> Include for foreach? src/master/allocator/sorter/drf/sorter.cpp (line 403) <https://reviews.apache.org/r/48455/#comment204122> Include for CHECK_SOME? src/master/allocator/sorter/drf/sorter.cpp (line 416) <https://reviews.apache.org/r/48455/#comment204124> Include for Option? - Benjamin Mahler On June 11, 2016, 8:27 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48455/ > ----------------------------------------------------------- > > (Updated June 11, 2016, 8:27 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Some cleanup for sorter.cpp. > > > Diffs > ----- > > src/master/allocator/sorter/drf/sorter.cpp > 65d473a5da0d846214c930c14d333040b2085b13 > > Diff: https://reviews.apache.org/r/48455/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
