> On June 21, 2016, 1:29 a.m., Vinod Kone wrote: > > include/mesos/v1/master.proto, lines 181-193 > > <https://reviews.apache.org/r/48751/diff/2/?file=1420363#file1420363line181> > > > > How about defining *top level* `Framework` and maybe `Executor` > > message? I think it could be reused by GET_FRAMEWORKS and GET_AGENTS calls? > > > > Infact, if Framework didn't contain `offers` we can move `Framework` > > and `Executor` to mesos.proto right next to `Task`.
Sounds good for top level in this file. Will do. - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48751/#review138723 ----------------------------------------------------------- On June 21, 2016, 9:37 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48751/ > ----------------------------------------------------------- > > (Updated June 21, 2016, 9:37 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5489 > https://issues.apache.org/jira/browse/MESOS-5489 > > > Repository: mesos > > > Description > ------- > > Implement GetState response for master API. > > The response protobuf message and new function `_getState` will be reused for > generating snapshot for Subscribe call in next patch. > > > Diffs > ----- > > include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 > include/mesos/v1/master/master.proto > c5b57ddc6aca0a62fb28523aee2fa579212da0ed > src/master/http.cpp 0196a79b4941ed6031afee8dfc35e11e23f07244 > src/master/master.hpp 2064f849edf6f78b009ecfcc4b15b6831834345c > src/tests/api_tests.cpp 55df322f6a843e52d67bb09d3fe763739515602b > > Diff: https://reviews.apache.org/r/48751/diff/ > > > Testing > ------- > > New test in MasterAPITest. > > > Thanks, > > Zhitao Li > >
