> On June 22, 2016, 6:29 a.m., Jay Guo wrote: > > include/mesos/master/master.proto, line 314 > > <https://reviews.apache.org/r/48751/diff/4/?file=1427225#file1427225line314> > > > > I feel marking fields as `required` is troublesome and it's actually > > discouraged in protobuf: > > https://developers.google.com/protocol-buffers/docs/proto#specifying-field-rules > > > > Before I raise it to broader audiences, I just wonder if we have a > > particular doing this? > > > > @vinodkone
*particular reason - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48751/#review139019 ----------------------------------------------------------- On June 22, 2016, 6:13 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48751/ > ----------------------------------------------------------- > > (Updated June 22, 2016, 6:13 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5489 > https://issues.apache.org/jira/browse/MESOS-5489 > > > Repository: mesos > > > Description > ------- > > Implement `GetState` response for master API. > > The response protobuf message and new function `_getState` > will be reused for generating snapshot for Subscribe call in next patch. > > > Diffs > ----- > > include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 > include/mesos/v1/master/master.proto > 11dfab318eb073908a9e302afa33b274fec63a16 > src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e > src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4 > src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2 > > Diff: https://reviews.apache.org/r/48751/diff/ > > > Testing > ------- > > New test in MasterAPITest. > > > Thanks, > > Zhitao Li > >
