----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48751/#review139277 -----------------------------------------------------------
include/mesos/master/master.proto (lines 223 - 224) <https://reviews.apache.org/r/48751/#comment204447> Per previous conversation with Jay Guo, I'm inclined to make most fields as optional for now unless there is very strong reason. I think upgrading from optional to required is possible if it's always set, but the otherway may not, right? include/mesos/v1/master/master.proto (lines 232 - 233) <https://reviews.apache.org/r/48751/#comment204448> Good point. Mistakenly thought that's not available in proto2. Will do. include/mesos/v1/master/master.proto (lines 234 - 235) <https://reviews.apache.org/r/48751/#comment204449> We haven't introduced a `message Agent` in this patch yet. There is some parallel conversation about unifying messages between various `Get*` methods in a differet patch from Jay Guo. I'm inclined to drop these two fields in this patch until we have consensus about what to do with agents. What do you think? - Zhitao Li On June 22, 2016, 5 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48751/ > ----------------------------------------------------------- > > (Updated June 22, 2016, 5 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5489 > https://issues.apache.org/jira/browse/MESOS-5489 > > > Repository: mesos > > > Description > ------- > > Implement `GetState` response for master API. > > The response protobuf message and new function `_getState` > will be reused for generating snapshot for Subscribe call in next patch. > > > Diffs > ----- > > include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 > include/mesos/v1/master/master.proto > 11dfab318eb073908a9e302afa33b274fec63a16 > src/master/http.cpp 7daaf12a4086635bbc5aba5e3375c95e8899ac6e > src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4 > src/tests/api_tests.cpp bf1a294f1fc3c8659c31115beee3876d4d0a45e2 > > Diff: https://reviews.apache.org/r/48751/diff/ > > > Testing > ------- > > New test in MasterAPITest. > > > Thanks, > > Zhitao Li > >
