----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49136/#review139514 -----------------------------------------------------------
include/mesos/master/master.proto (lines 307 - 309) <https://reviews.apache.org/r/49136/#comment204782> make these optional. include/mesos/master/master.proto (line 309) <https://reviews.apache.org/r/49136/#comment204778> make this optional include/mesos/master/master.proto (lines 311 - 315) <https://reviews.apache.org/r/49136/#comment204781> I would order these so: ``` repeated TaskInfo pending_tasks = 7; repeated Task tasks = 8; repeated Task completed_tasks = 9; repeated Executor executors = 10; repeated Offer offers = 11; ``` include/mesos/master/master.proto (line 317) <https://reviews.apache.org/r/49136/#comment204780> s/used/allocated/ - Vinod Kone On June 26, 2016, 1:53 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49136/ > ----------------------------------------------------------- > > (Updated June 26, 2016, 1:53 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: mesos-5492 > https://issues.apache.org/jira/browse/mesos-5492 > > > Repository: mesos > > > Description > ------- > > Add 'Framework' protobuf message to master/master.proto & > v1/master/master.proto. > > > Diffs > ----- > > include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 > include/mesos/v1/master/master.proto > 11dfab318eb073908a9e302afa33b274fec63a16 > > Diff: https://reviews.apache.org/r/49136/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >