> On June 27, 2016, 12:36 a.m., Anand Mazumdar wrote: > > src/master/http.cpp, lines 1505-1506 > > <https://reviews.apache.org/r/49225/diff/1/?file=1430126#file1430126line1505> > > > > Do we need this explicit check here? I can understand why we > > introduced/need it in `GET_LEADER` but why here? Bad Copy/Paste?
Haha..No, it was not bad copy/paste.. I did it deliberately.. in reserve() function, you can find : // When current master is not the leader, redirect to the leading master. if (!master->elected()) { return redirect(request); } So, I put this check in reserveResource() function as reservation is done through elected master. Still, you want me to remove this check? - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/#review139506 ----------------------------------------------------------- On June 25, 2016, 6:52 a.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49225/ > ----------------------------------------------------------- > > (Updated June 25, 2016, 6:52 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5499 > https://issues.apache.org/jira/browse/MESOS-5499 > > > Repository: mesos > > > Description > ------- > > Implemented RESERVE_RESOURCES Call in v1 master API. > > > Diffs > ----- > > src/master/http.cpp 70f084b84db90fde20c05d2354be190f28e72996 > src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa > src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb > > Diff: https://reviews.apache.org/r/49225/diff/ > > > Testing > ------- > > > Thanks, > > Abhishek Dasgupta > >