> On June 30, 2016, 1:01 a.m., Klaus Ma wrote: > > src/master/flags.cpp, line 437 > > <https://reviews.apache.org/r/48895/diff/3/?file=1432431#file1432431line437> > > > > s/client/framework > > > > Mesos user does not know client. > > Guangya Liu wrote: > I think that here not only framework, but also roles, I will udpate it to > > "A comma-separated list of the resource names that will be ignored\n" > "by WDRF sorter when calculating share for clients (frameworks or > roles).\n");
Only the code reader known what's `clients` means in sorter, we did not need to expose it to end user; using `framework/roles` directly is better. - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48895/#review140011 ----------------------------------------------------------- On June 30, 2016, 3:51 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48895/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 3:51 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5620 > https://issues.apache.org/jira/browse/MESOS-5620 > > > Repository: mesos > > > Description > ------- > > Added allocator_fairness_excluded_resource_names flag to master. > > > Diffs > ----- > > src/master/flags.hpp 735367ff5412d611f4eae6cb63dd4829c4338002 > src/master/flags.cpp b6b1603f02d3c6f861edad3de770ecb3fcad0057 > > Diff: https://reviews.apache.org/r/48895/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
