----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48895/#review140237 -----------------------------------------------------------
Ship it! Here is a suggestion for a more descriptive commit message: ``` Added a flag for excluding resources from fair sharing. The intention of this flag is for the operator to specify resources types (e.g. "cpus", "mem", "gpus", etc) that should not be fairly shared. The implementation of will not count the specified resources towards a role's share of the cluster. This may be useful in cases where our fair sharing implementation currently has limitations. E.g. See the problem of "scarce" resources: http://www.mail-archive.com/dev@mesos.apache.org/msg35631.html https://issues.apache.org/jira/browse/MESOS-5377 ``` src/master/flags.cpp (lines 436 - 438) <https://reviews.apache.org/r/48895/#comment205616> Hm.. the user doesn't know about sorters, how about this suggestion, which is a bit more high level: ``` + add(&Flags::fair_sharing_excluded_resource_names, + "fair_sharing_excluded_resource_names", + "A comma-separated list of the resource names (e.g. 'gpus')\n" + "that will be excluded from fair sharing constraints.\n" + "This may be useful in cases where the fair sharing\n" + "implementation currently has limitations. E.g. See the\n" + "problem of \"scarce\" resources:\n" + " http://www.mail-archive.com/dev@mesos.apache.org/msg35631.html\n"; + " https://issues.apache.org/jira/browse/MESOS-5377";); ``` - Benjamin Mahler On June 30, 2016, 7:51 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48895/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 7:51 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5620 > https://issues.apache.org/jira/browse/MESOS-5620 > > > Repository: mesos > > > Description > ------- > > Added allocator_fairness_excluded_resource_names flag to master. > > > Diffs > ----- > > src/master/flags.hpp 735367ff5412d611f4eae6cb63dd4829c4338002 > src/master/flags.cpp b6b1603f02d3c6f861edad3de770ecb3fcad0057 > > Diff: https://reviews.apache.org/r/48895/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
