----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49816/#review141630 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 138) <https://reviews.apache.org/r/49816/#comment206967> Instead of passing the PID to subsystem, I think we just pass the needed callback method to subsystem just like how Mesos master passes callback method to allocator. You can take a look at the following code as a reference: https://github.com/apache/mesos/blob/0.28.2/src/master/master.cpp#L684:L688 - Qian Zhang On July 9, 2016, 6:16 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49816/ > ----------------------------------------------------------- > > (Updated July 9, 2016, 6:16 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::initialize`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/49816/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
