----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49823/#review142516 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp (line 122) <https://reviews.apache.org/r/49823/#comment208071> Why is this a virtual method? src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 448) <https://reviews.apache.org/r/49823/#comment208070> I do not think you need the period in the end. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 459) <https://reviews.apache.org/r/49823/#comment208072> I do not think we need to call `_update()`, instead the following should be enough: ``` return collect(updates).then([]() { return Nothing(); }); ``` You can take a look at the following code as a reference: https://github.com/apache/mesos/blob/1.0.0-rc2/src/slave/containerizer/mesos/isolators/gpu/isolator.cpp#L241 src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 465) <https://reviews.apache.org/r/49823/#comment208073> I do not think we need this method. - Qian Zhang On July 15, 2016, 11:33 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49823/ > ----------------------------------------------------------- > > (Updated July 15, 2016, 11:33 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::update`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > c57baec88437f68886702a40ec8a6a6458546119 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 4a9f55bf3b217405bf90943f27a976422877a99e > > Diff: https://reviews.apache.org/r/49823/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
