----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49823/#review143327 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 440 - 448) <https://reviews.apache.org/r/49823/#comment209110> I would suggest to merge these codes into a single line `return collect(updates).then([]() { return Nothing(); });`. - Qian Zhang On July 22, 2016, 3:06 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49823/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 3:06 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::update`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 4a9f55bf3b217405bf90943f27a976422877a99e > > Diff: https://reviews.apache.org/r/49823/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
