> On July 25, 2016, 3:06 a.m., zhou xing wrote: > > src/master/http.cpp, line 491 > > <https://reviews.apache.org/r/50246/diff/1/?file=1448176#file1448176line491> > > > > just wonder if we can just use regexp to extract string > > 'application/json' or 'application/x-protobuf' from Content-Type, as we are > > not interested in charset parse/validation?
Last I noticed people saying regex doesn't work with Mesos. I didn't try that myself though. Do mesos have any regex helper? I am not aware of any such. What do you say?? - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50246/#review143346 ----------------------------------------------------------- On July 20, 2016, 6:11 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50246/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 6:11 p.m.) > > > Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone. > > > Bugs: MESOS-5858 > https://issues.apache.org/jira/browse/MESOS-5858 > > > Repository: mesos > > > Description > ------- > > Earlier operator v1 api was not supporting charset utf-8 > specified in 'Content Type'. In this patch, mesos master > is modified to support contentType with and without > charset utf-8 specified. > > > Diffs > ----- > > src/master/http.cpp 1cbec976ccedae81def388c62889624aaf9a794e > src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad > > Diff: https://reviews.apache.org/r/50246/diff/ > > > Testing > ------- > > On Ubuntu 16.04: > sudo GTEST_FILTER="*MasterAPITest.*" make -j4 check > > Manual Testing: > 1. sudo ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos > 2. Ran Poster application in firefox and sent a POST data for GET_VERSION > call to http://127.0.0.1:5050/api/v1 with contentType as application/json; > charset=utf-8 > > > Thanks, > > Abhishek Dasgupta > >
