----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50248/#review143273 -----------------------------------------------------------
src/java/jni/construct.cpp (line 460) <https://reviews.apache.org/r/50248/#comment209054> s/NULL/nullptr/ to be consistent with above? - Vinod Kone On July 20, 2016, 7:01 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50248/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 7:01 p.m.) > > > Review request for mesos, Joris Van Remoortere and Vinod Kone. > > > Bugs: MESOS-5788 > https://issues.apache.org/jira/browse/MESOS-5788 > > > Repository: mesos > > > Description > ------- > > These would be used later in the chain for the making JNI > calls to v1 Mesos implementation in native code. > > > Diffs > ----- > > src/java/jni/construct.cpp e5c070c819698729780b487ebd214ee43f15ae87 > src/java/jni/convert.cpp 45ff488b921c0254761ec0a7b5c06608aa86ca3f > > Diff: https://reviews.apache.org/r/50248/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >