> On 七月 27, 2016, 7:55 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 1357 > > <https://reviews.apache.org/r/50123/diff/1/?file=1445669#file1445669line1357> > > > > Seems no one is using `nvidiaGpus`? It should be set as parameter for > > `--device` when running container. > > Guangya Liu wrote: > I would suggest you create a new patch to handle `nvidiaGpus`, getting > all of the logic for handling `nvidiaGpus` in this patch and > https://reviews.apache.org/r/50124/ to create a new patch. > > Also seems the name of `nvidiaGpuDevices` is better than `nvidiaGpus`.
Will do, thanks! > On 七月 27, 2016, 7:55 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 1550-1561 > > <https://reviews.apache.org/r/50123/diff/1/?file=1445669#file1445669line1550> > > > > Why release the gpu resources here? The `update` will also be called > > when the executor is launched. This logic is called when the task terminates. We allocate GPU in `Future<Nothing> DockerContainerizerProcess::update()` when a task launches, and release GPU in `Future<Nothing> DockerContainerizerProcess::_update()` when a task terminates. - Yubo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review143692 ----------------------------------------------------------- On 七月 18, 2016, 9:17 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50123/ > ----------------------------------------------------------- > > (Updated 七月 18, 2016, 9:17 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > This added 'NvidiaGpuAllocator' to docker containerizer so that the > docker containerizer can use it to allocate GPUs to the task with 'gpus' > resource. Also, allocated GPUs will automatically deallocated after the > job destroyed. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885 > src/slave/containerizer/docker.cpp f1ecf3b25d85597f6c3dcaa47968860ed119dbd5 > > Diff: https://reviews.apache.org/r/50123/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
