----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review143844 -----------------------------------------------------------
src/slave/containerizer/docker.cpp (lines 1305 - 1311) <https://reviews.apache.org/r/50123/#comment209776> One question for this: I found that the `nvidia devices` was created as a `devices string` here when `launchExecutorContainer` and then in https://reviews.apache.org/r/50125/ , the `devices string` was re-constructed when `launchTask`,why not construct the `docker run` parameters for `nvidia devices` directly in `launchTask`? - Guangya Liu On 七月 18, 2016, 9:17 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50123/ > ----------------------------------------------------------- > > (Updated 七月 18, 2016, 9:17 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > This added 'NvidiaGpuAllocator' to docker containerizer so that the > docker containerizer can use it to allocate GPUs to the task with 'gpus' > resource. Also, allocated GPUs will automatically deallocated after the > job destroyed. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885 > src/slave/containerizer/docker.cpp f1ecf3b25d85597f6c3dcaa47968860ed119dbd5 > > Diff: https://reviews.apache.org/r/50123/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >