----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review143822 -----------------------------------------------------------
Ship it! I fixed a few style nits while committing. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 141) <https://reviews.apache.org/r/49819/#comment209754> No need to print containerId here because caller should be the one that does that. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 152) <https://reviews.apache.org/r/49819/#comment209755> Why `_path` here? - Jie Yu On July 27, 2016, 6:21 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49819/ > ----------------------------------------------------------- > > (Updated July 27, 2016, 6:21 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::prepare`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 348f105f9c3109a02f1dde0649f1b829cb9ddd04 > > Diff: https://reviews.apache.org/r/49819/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
