----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/#review143328 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 308 - 314) <https://reviews.apache.org/r/49819/#comment209111> I am not sure why we need this `onAny()` call, I would suggest to kill it so that the code here will be: ``` return collect(prepares) .then(defer( PID<CgroupsIsolatorProcess>(this), &CgroupsIsolatorProcess::update, containerId, containerConfig.executor_info().resources() )) .then([]() -> Future<Option<ContainerLaunchInfo>> { return None(); }); ``` - Qian Zhang On July 22, 2016, 3:05 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49819/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 3:05 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::prepare`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > c57baec88437f68886702a40ec8a6a6458546119 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 4a9f55bf3b217405bf90943f27a976422877a99e > > Diff: https://reviews.apache.org/r/49819/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
