----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/#review144432 -----------------------------------------------------------
Can you please rebase against the `master` branch so I can apply and test this review? 3rdparty/cmake/Mesos3rdpartyConfigure.cmake (line 51) <https://reviews.apache.org/r/49862/#comment210449> You're right to split this out, but just for my own education, was there a specific reason you did it? src/CMakeLists.txt (line 490) <https://reviews.apache.org/r/49862/#comment210450> Hmm, is this required? It should be `ON` by default for shared libraries, no? src/slave/cmake/SlaveConfigure.cmake (line 70) <https://reviews.apache.org/r/49862/#comment210448> Hmm. Can you talk a bit about why we're adding this here? The agent doesn't depend on leveldb, right? Only the master does? I'm just trying to think about how we actually want to add this. Historically there has been some ambition to write this in a way that we can get rid of libmesos and split it up into libagent and libmaster. If we maintain the agent dependencies as separated from the master dependencies, we will get some duplication in the shared dependencies, but it will also be easier (hopefully) to reason about what depends on what. What do you think? - Alex Clemmer On July 19, 2016, 9:36 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49862/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 9:36 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Changed libmesos from static library to a shared library. > > > Diffs > ----- > > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > eeb27860f6f95d297ccfe273ed76de5355b50ff8 > 3rdparty/http-parser/CMakeLists.txt.template > 9a671973b754095e1de917f135a7deb978fb6eb6 > src/CMakeLists.txt bde76f7840afe55f20d7551b3f7e5fe522f7f326 > src/master/cmake/MasterConfigure.cmake > 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 > src/slave/cmake/SlaveConfigure.cmake > ced57496970f1d7edf9e7e443b22d14d2ee948f0 > > Diff: https://reviews.apache.org/r/49862/diff/ > > > Testing > ------- > > cmake .. && make > > > Thanks, > > Srinivas Brahmaroutu > >
