> On Aug. 2, 2016, 1:31 a.m., Alex Clemmer wrote: > > src/slave/cmake/SlaveConfigure.cmake, line 70 > > <https://reviews.apache.org/r/49862/diff/10/?file=1447569#file1447569line70> > > > > Oh. This is especially pertinent given that you seem to remove this > > line in #49874.
I cannot recollect that this is intentional. I fixed the issue. - Srinivas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/#review144435 ----------------------------------------------------------- On Aug. 3, 2016, 4:40 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49862/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2016, 4:40 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Changed libmesos from static library to a shared library. > > > Diffs > ----- > > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > eeb27860f6f95d297ccfe273ed76de5355b50ff8 > 3rdparty/http-parser/CMakeLists.txt.template > 9a671973b754095e1de917f135a7deb978fb6eb6 > src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 > src/master/cmake/MasterConfigure.cmake > 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 > src/slave/cmake/SlaveConfigure.cmake > b339239761a5de321d65b92376dae69c339bee5c > > Diff: https://reviews.apache.org/r/49862/diff/ > > > Testing > ------- > > cmake .. && make > > > Thanks, > > Srinivas Brahmaroutu > >
