> On July 28, 2016, 2:23 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 961-965 > > <https://reviews.apache.org/r/49852/diff/5/?file=1453265#file1453265line961> > > > > Should this be a CHECK()?
I return `Failure` here, feel free to reopen this if you prefer `CHECK`. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/#review143933 ----------------------------------------------------------- On Aug. 2, 2016, 5:49 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49852/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2016, 5:49 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5046 > https://issues.apache.org/jira/browse/MESOS-5046 > > > Repository: mesos > > > Description > ------- > > Implemented `NetClsSubsystem`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 179eb070d9621348bd7fa7d9a093a857ff0f2855 > src/slave/containerizer/mesos/isolators/cgroups/constants.hpp > c45d88092f3fe497373dfeaa8346aef9126c7b8b > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp > 5f52a076a1fa3a21d886cb961ddeed5046a38d7c > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp > a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 > > Diff: https://reviews.apache.org/r/49852/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
