> On July 28, 2016, 11:01 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp, line 359 > > <https://reviews.apache.org/r/49852/diff/5/?file=1453264#file1453264line359> > > > > Where is the implementation of this class `NetClsHandleManager`? > > haosdent huang wrote: > Would move it from `net_cls.cpp` into `subsystem.cpp` in the following > patches.
Basically I think we should make each patch as atomic as possible, so I would suggest to move the implementation of `NetClsHandleManager` from https://reviews.apache.org/r/50750 to this patch, and I see the subject of https://reviews.apache.org/r/50750 is `Removed CgroupsNetClsIsolatorProcess.`, so it is a bit strange that we introduce a new class in a patch which is trying to remove something. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/#review143943 ----------------------------------------------------------- On Aug. 4, 2016, 1:58 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49852/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 1:58 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5046 > https://issues.apache.org/jira/browse/MESOS-5046 > > > Repository: mesos > > > Description > ------- > > Implemented `NetClsSubsystem`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 2659252d8cffcefc233bc85fb4707c8147272737 > src/slave/containerizer/mesos/isolators/cgroups/constants.hpp > c45d88092f3fe497373dfeaa8346aef9126c7b8b > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp > 5f52a076a1fa3a21d886cb961ddeed5046a38d7c > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp > a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 > > Diff: https://reviews.apache.org/r/49852/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
