> On Aug. 3, 2016, 6:12 p.m., Neil Conway wrote: > > src/master/master.cpp, line 5142 > > <https://reviews.apache.org/r/50723/diff/1/?file=1460860#file1460860line5142> > > > > Seems like we should still be logging when we get a status update from > > an unknown framework.
+1, my bad. > On Aug. 3, 2016, 6:12 p.m., Neil Conway wrote: > > src/tests/master_tests.cpp, line 4665 > > <https://reviews.apache.org/r/50723/diff/1/?file=1460861#file1460861line4665> > > > > Should we also check that the task correctly transitions to a terminal > > state in the master? I had punted on this for now and just ensuring if the resources have been correctly recovered. I left a TODO to address this for later. > On Aug. 3, 2016, 6:12 p.m., Neil Conway wrote: > > src/master/master.cpp, line 5163 > > <https://reviews.apache.org/r/50723/diff/1/?file=1460860#file1460860line5163> > > > > `getFramework()` might return non-`nullptr` for a disconnected (but > > still registered) framework, so I think you should rephrase this. I had copied this comment over from similar pre-existing comments in this file. Would file a follow up JIRA issue to revisit some of them. > On Aug. 3, 2016, 6:12 p.m., Neil Conway wrote: > > src/master/master.cpp, line 5185 > > <https://reviews.apache.org/r/50723/diff/1/?file=1460860#file1460860line5185> > > > > Should we call such a status update "valid"? We didn't before, now we > > will. Not sure new behavior is wrong but seems worth discussing. +1, Continuing this discussion on a follow up review comment from Adam. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/#review144633 ----------------------------------------------------------- On Aug. 3, 2016, 8:44 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50723/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2016, 8:44 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5930 > https://issues.apache.org/jira/browse/MESOS-5930 > > > Repository: mesos > > > Description > ------- > > The master's status handler function used to ignore the status updates > from the agents for frameworks not yet re-connected with the master > upon a failover. This change modifies that logic to still update > the local state and not bail out early. > > > Diffs > ----- > > src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c > src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b > > Diff: https://reviews.apache.org/r/50723/diff/ > > > Testing > ------- > > make check (gtest_repeat=100) > > > Thanks, > > Anand Mazumdar > >
