> On Aug. 3, 2016, 6:12 p.m., Neil Conway wrote: > > src/tests/master_tests.cpp, line 4665 > > <https://reviews.apache.org/r/50723/diff/1/?file=1460861#file1460861line4665> > > > > Should we also check that the task correctly transitions to a terminal > > state in the master? > > Anand Mazumdar wrote: > I had punted on this for now and just ensuring if the resources have been > correctly recovered. I left a TODO to address this for later.
The observed behavior in the bug report is about task statuses, not resource allocation; those are fairly different things. I'd personally prefer to see a test for task statuses be included as part of this change. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/#review144633 ----------------------------------------------------------- On Aug. 3, 2016, 11:14 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50723/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2016, 11:14 p.m.) > > > Review request for mesos, Adam B, Neil Conway, and Vinod Kone. > > > Bugs: MESOS-5930 > https://issues.apache.org/jira/browse/MESOS-5930 > > > Repository: mesos > > > Description > ------- > > The master's status handler function used to ignore the status updates > from the agents for frameworks not yet re-connected with the master > upon a failover. This change modifies that logic to still update > the local state and not bail out early. > > > Diffs > ----- > > src/master/master.cpp 17d5c5875647bb35e2518cc2bd9e134b020c05bf > src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b > > Diff: https://reviews.apache.org/r/50723/diff/ > > > Testing > ------- > > make check (gtest_repeat=100) > > > Thanks, > > Anand Mazumdar > >
