----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50762/#review144680 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On Aug. 3, 2016, 7:10 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50762/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2016, 7:10 p.m.) > > > Review request for mesos, Benjamin Mahler and Jie Yu. > > > Bugs: MESOS-5982 > https://issues.apache.org/jira/browse/MESOS-5982 > > > Repository: mesos > > > Description > ------- > > Previously, when building the volume, we would error out if a binary > we were trying to add was not found on the host filesystem. However, > these are not the semantics that we want. By design, we list all the > binaries the *may* exist on the filesystem that we want to put in the > volume, not all of the binaries that *must* exist. To this end, we > should simply skip any unfound binaries and move on to the next one > instead of erroring out. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/gpu/volume.cpp > 478e106cdaa025af92117f14be91ec9e1c70425b > > Diff: https://reviews.apache.org/r/50762/diff/ > > > Testing > ------- > > GTEST_FILTER="" make -j check > src/mesos-tests > sudo src/mesos-tests > > > Thanks, > > Kevin Klues > >
