----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review144767 -----------------------------------------------------------
include/mesos/mesos.proto (lines 348 - 355) <https://reviews.apache.org/r/49360/#comment210881> Here is my suggestion for the proto: ``` message Socket { enum Protocol { UNKNOWN = 0; TCP = 1; UDP = 2; // This is post-MVP. } required Protocol protocol = 1 [default = TCP]; // Port expected to be open. required uint32 port = 2; } ``` include/mesos/mesos.proto (line 349) <https://reviews.apache.org/r/49360/#comment210882> I can imagine using UDP in the future, hence the name may be a bit unfortunate. include/mesos/mesos.proto (line 354) <https://reviews.apache.org/r/49360/#comment210884> As discussed on the community slack, we may avoid this and deduce the domain ourselves. - Alexander Rukletsov On Aug. 1, 2016, 1:15 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49360/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2016, 1:15 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, > Jie Yu, and Timothy Chen. > > > Bugs: MESOS-3567 > https://issues.apache.org/jira/browse/MESOS-3567 > > > Repository: mesos > > > Description > ------- > > Supported TCP check in health check. > > > Diffs > ----- > > include/mesos/mesos.proto 590e169108b2ce5881734ec7f4b01cef9937461a > include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 > src/health-check/health_checker.hpp > b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 > src/health-check/health_checker.cpp > 585a0b565d948cfa292bad818a710501a4ce0daf > > Diff: https://reviews.apache.org/r/49360/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
