-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
-----------------------------------------------------------
(Updated Aug. 10, 2016, 11:09 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Review comments and rebased.
Bugs: MESOS-5771
https://issues.apache.org/jira/browse/MESOS-5771
Repository: mesos
Description (updated)
-------
Allocations test has the following resource configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
resources; and offers from every other alternate slave contains
a shared resource.
This test is parameterized based on number of agents, number of
frameworks and resource configuration.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp
cbed333f497016fe2811f755028796012b41db77
Diff: https://reviews.apache.org/r/49571/diff/
Testing (updated)
-------
All tests passed.
Allocations benchmark test results
==================================
Support of shared resources has a small impact (roughly 5%-7%) on runtime
performance in allocations as compared to HEAD (without shared resources).
Also, there is no visible impact in performance when shared resources are added
in the tests.
Following is a snapshot with 1000 agents and 200 frameworks.
With the patch (and no shared resources)
----------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6572us
Added 1000 agents in 1.820284secs
round 0 allocate() took 1.602476secs to make 1000 offers
round 50 allocate() took 1.586638secs to make 1000 offers
round 100 allocate() took 1.588735secs to make 1000 offers
round 150 allocate() took 1.581553secs to make 1000 offers
round 199 allocate() took 1.595088secs to make 1000 offers
With the patch (and shared resources on all agents)
---------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/10
Using 1000 agents and 200 frameworks with resource type 1
Added 200 frameworks in 6869us
Added 1000 agents in 1.847318secs
round 0 allocate() took 1.606464secs to make 1000 offers
round 50 allocate() took 1.603727secs to make 1000 offers
round 100 allocate() took 1.630528secs to make 1000 offers
round 150 allocate() took 1.60693secs to make 1000 offers
round 199 allocate() took 1.613754secs to make 1000 offers
With the patch (and shared resources on alternate agents)
---------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/11
Using 1000 agents and 200 frameworks with resource type 2
Added 200 frameworks in 6903us
Added 1000 agents in 1.856714secs
round 0 allocate() took 1.621012secs to make 1000 offers
round 50 allocate() took 1.60385secs to make 1000 offers
round 100 allocate() took 1.64289secs to make 1000 offers
round 150 allocate() took 1.654631secs to make 1000 offers
round 199 allocate() took 1.609998secs to make 1000 offers
Based on HEAD, with all regular resources (no shared resources in HEAD
supported)
---------------------------------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6801us
Added 1000 agents in 1.721447secs
round 0 allocate() took 1.502953secs to make 1000 offers
round 50 allocate() took 1.520157secs to make 1000 offers
round 100 allocate() took 1.517221secs to make 1000 offers
round 150 allocate() took 1.526446secs to make 1000 offers
round 199 allocate() took 1.538005secs to make 1000 offers
Thanks,
Anindya Sinha
