----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51171/#review146129 -----------------------------------------------------------
It was my bad. After looking at the code closely, I realized that we should probably use dependency injection for the new isolator. In other words, `ImageVolumeIsolator::create` will take a flags as well as a `Shared<Provisioner>`. Take a look at the GPU isolator see how to inject provisioner. src/slave/containerizer/mesos/provisioner/provisioner.hpp (line 119) <https://reviews.apache.org/r/51171/#comment212507> No need for this. You can just save it using a file local global variable. src/tests/containerizer/mesos_containerizer_tests.cpp (lines 774 - 775) <https://reviews.apache.org/r/51171/#comment212505> Fix indentation? src/tests/containerizer/mesos_containerizer_tests.cpp (lines 778 - 780) <https://reviews.apache.org/r/51171/#comment212506> Ditto. - Jie Yu On Aug. 17, 2016, 8:44 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51171/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2016, 8:44 a.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, Artem > Harutyunyan, Jie Yu, Kevin Klues, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Currently, the provisioner is constructed in mesos containerizer create > as an 'owned' pointer. However, if we want to support image volumes as > a isolator, the volume/image isolator needs the provisioner object. We > have to make sure the provisioner is singliton and reachable in both > mesos containerizer and the isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/provisioner.hpp > 8f378f6fea3fa4b6d1b7d079c7f280790b30589e > src/slave/containerizer/mesos/provisioner/provisioner.cpp > ad19feccf08112f94d6514a134963c54ca541e88 > src/tests/containerizer/mesos_containerizer_tests.cpp > 4a49247a8b8c6995535a865266f85f2aa31fb4de > > Diff: https://reviews.apache.org/r/51171/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
