> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, lines 20-25 > > <https://reviews.apache.org/r/50123/diff/8/?file=1480590#file1480590line20> > > > > What does adding all of these headers have to do with this patch? They > > may be needed, but I don't see why they would be part of this patch, > > specifically. > > Guangya Liu wrote: > OK, then we can split this to two patches, one for adding those header > files and the other is for gpu related.
I'll split this to two patches, as Guangya suggected. How do you think Kevin? > On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 1284 > > <https://reviews.apache.org/r/50123/diff/8/?file=1480591#file1480591line1284> > > > > I would remove this temporary variable and just call the following: > > ``` > > Option<double> gpus = taskInfo->resources().gpus(); > > ``` I changed to `Option<double> gpus = Resources(taskInfo->resources()).gpus();` because gpus() is not a member function of `google::protobuf::RepeatedPtrField<Resource>` type. Make sense? > On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 19 > > <https://reviews.apache.org/r/50123/diff/8/?file=1480591#file1480591line19> > > > > Again, it's not clear why this is added as part of this commit. I.e. I > > don't see `set` being used anwywhere in the code that's being added. removed - Yubo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review146724 ----------------------------------------------------------- On 八月 22, 2016, 10:11 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50123/ > ----------------------------------------------------------- > > (Updated 八月 22, 2016, 10:11 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > This added 'NvidiaGpuAllocator' to docker containerizer process so that > docker containerizer process is ready to use it to allocate GPUs to task > with 'gpus' resource. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d > src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723 > src/tests/mesos.hpp ad31276aeb2cb7ed5ba3e091a9085f35addf17c4 > src/tests/mesos.cpp 62e8fcc6fa7bd856aab6148ca6e6cad66b436f04 > > Diff: https://reviews.apache.org/r/50123/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
