----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51095/#review146874 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/spec.proto (line 71) <https://reviews.apache.org/r/51095/#comment213648> s/Cni// `cni` is already part of the namespace prefix src/slave/containerizer/mesos/isolators/network/cni/spec.proto (line 72) <https://reviews.apache.org/r/51095/#comment213649> `s/cni_version/cniVersion` looking at CNI spec: ``` { "cniVersion": "0.2.0", "code": <numeric-error-code>, "msg": <short-error-message>, "details": <long-error-message> (optional) } ``` - Jie Yu On Aug. 15, 2016, 5:24 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51095/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 5:24 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-6023 > https://issues.apache.org/jira/browse/MESOS-6023 > > > Repository: mesos > > > Description > ------- > > Adding protobuf to represent errors returned by CNI plugins. > > This will be used by CNI plugins such as `PortMapper` to report errors to the > `network/cni` isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto > 8419bc11d14aa29110377248a92ebb1aa4baf486 > > Diff: https://reviews.apache.org/r/51095/diff/ > > > Testing > ------- > > make > > > Thanks, > > Avinash sridharan > >
