----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51095/#review146925 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/spec.cpp (line 34) <https://reviews.apache.org/r/51095/#comment213753> Why do we need to make this change? And it seems this change is not related to the purpose of this patch (adding protobuf). - Qian Zhang On Aug. 26, 2016, 8:26 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51095/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 8:26 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-6023 > https://issues.apache.org/jira/browse/MESOS-6023 > > > Repository: mesos > > > Description > ------- > > Adding protobuf to represent errors returned by CNI plugins. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/spec.cpp > 938a9f3bff2a95c8591450f0edafaddb01833e59 > src/slave/containerizer/mesos/isolators/network/cni/spec.proto > 8419bc11d14aa29110377248a92ebb1aa4baf486 > > Diff: https://reviews.apache.org/r/51095/diff/ > > > Testing > ------- > > make > > > Thanks, > > Avinash sridharan > >
