----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/#review146938 -----------------------------------------------------------
Fix it, then Ship it! src/health-check/health_checker.cpp (line 121) <https://reviews.apache.org/r/51069/#comment213809> We can use VLOG(1) here as well. src/health-check/health_checker.cpp (line 169) <https://reviews.apache.org/r/51069/#comment213802> s/pass/passed src/health-check/health_checker.cpp (line 292) <https://reviews.apache.org/r/51069/#comment213806> s/sss/ss : ) How about: "Killing the command health check process " src/health-check/health_checker.cpp (lines 299 - 300) <https://reviews.apache.org/r/51069/#comment213805> Fits one line. - Alexander Rukletsov On Aug. 25, 2016, 1:24 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51069/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 1:24 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón > Kleiman, Gilbert Song, Jie Yu, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > * Removed blocking `Future::await` call. > * Read stdout and stderr of the health check command. > * Adjust the level of some logs. > * Adjust some minor styles. > * Change the interfaces of different health check handlers to > `Future<Nothing>` to make errors handling more easier. > > > Diffs > ----- > > src/health-check/health_checker.hpp > b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 > src/health-check/health_checker.cpp > 45a5fe00a95a6e88b1990c1396e03082feb202bc > > Diff: https://reviews.apache.org/r/51069/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >