> On Aug. 26, 2016, 11:24 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.cpp, line 306 > > <https://reviews.apache.org/r/51069/diff/8/?file=1485794#file1485794line306> > > > > s/sss/ss : ) > > How about: > > "Killing the command health check process "
Probably fits one line after the change. > On Aug. 26, 2016, 11:24 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.cpp, lines 314-315 > > <https://reviews.apache.org/r/51069/diff/8/?file=1485794#file1485794line314> > > > > Fits one line. But not if you add "; aborting" : ) - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/#review146938 ----------------------------------------------------------- On Aug. 26, 2016, 12:52 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51069/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 12:52 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón > Kleiman, Gilbert Song, Jie Yu, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > * Removed blocking `Future::await` call. > * Adjust the level of some logs. > * Adjust style. > * Change the interface of health check handlers to > `Future<Nothing>` to make errors handling more easier. > > > Diffs > ----- > > src/health-check/health_checker.hpp > b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 > src/health-check/health_checker.cpp > 45a5fe00a95a6e88b1990c1396e03082feb202bc > > Diff: https://reviews.apache.org/r/51069/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
