> On Aug. 24, 2016, 9:28 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/include/process/windows/subprocess.hpp, line 68 > > <https://reviews.apache.org/r/51233/diff/2/?file=1479630#file1479630line68> > > > > I checked this: > > > > https://msdn.microsoft.com/en-us/library/windows/desktop/bb762270(v=vs.85).aspx > > > > Which says: > > > If th[e second] parameter is NULL, the returned environment block > > contains system variables only. > > > > s/getCUEnvironment/getSystemEnvironment/
Correct; I think we what to use the system environment for mesos-executor. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51233/#review146706 ----------------------------------------------------------- On Aug. 19, 2016, 5:38 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51233/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2016, 5:38 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, > Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Build a clean `Windows` environment for `mesos-executor`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/windows/subprocess.hpp > 6bb54c878fbdc4b53c9d4f3298530cbcf55d88b8 > > Diff: https://reviews.apache.org/r/51233/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >
