----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51233/#review147054 -----------------------------------------------------------
Ship it! I can tweak the following before committing. 3rdparty/libprocess/include/process/windows/subprocess.hpp (line 127) <https://reviews.apache.org/r/51233/#comment214056> Considering the change in behavior, I think a comment like this will be appropriate: ``` // NOTE: This function will add the system's environment variables into // the returned string. These variables take precedence over the provided // `env` and are generally necessary in order to launch things on Windows. ``` 3rdparty/libprocess/include/process/windows/subprocess.hpp (lines 136 - 137) <https://reviews.apache.org/r/51233/#comment214052> This can be: ``` systemEnvironment.isSome() && systemEnvironment.get().size() > 0 ``` - Joseph Wu On Aug. 26, 2016, 10:38 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51233/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 10:38 a.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, > Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Added a clean `Windows` environment for `mesos-executor`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/windows/subprocess.hpp > 6bb54c878fbdc4b53c9d4f3298530cbcf55d88b8 > > Diff: https://reviews.apache.org/r/51233/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >
