> On Sept. 6, 2016, 2:14 p.m., Vinod Kone wrote: > > src/tests/partition_tests.cpp, line 710 > > <https://reviews.apache.org/r/50706/diff/2/?file=1487823#file1487823line710> > > > > hmm. didn't realize that the TODO in `Master::reconcile` regarding > > assumption is actually wrong! tasks could be unknown to the master but > > known to the agent. not sure why we made that assumption. > > Neil Conway wrote: > I believe that the comment in `Master::reconcile` assumes that the master > hasn't failed over (see the `NOTE` at the top of the function). > > Vinod Kone wrote: > yes, but this test exercises the scenario where the master doesn't > failover but still has no idea about the tasks on a re-registering agent!
This test does involve (simulated) master failover, though, which is why the master doesn't know about the tasks on the reregistering agent. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50706/#review147827 ----------------------------------------------------------- On Sept. 6, 2016, 3:24 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50706/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 3:24 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4049 > https://issues.apache.org/jira/browse/MESOS-4049 > > > Repository: mesos > > > Description > ------- > > Added test cases for PARTITION_AWARE behavior. > > > Diffs > ----- > > src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 > > Diff: https://reviews.apache.org/r/50706/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
