> On Sept. 6, 2016, 4:16 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.hpp, line 333 > > <https://reviews.apache.org/r/51668/diff/1/?file=1492306#file1492306line333> > > > > Any reason not use a 'vector'? > > Jie Yu wrote: > IN fact, why not use hashset here?
Actually, we dont track the containerIDs in a consistently ways. We used list, vector, hashset in our code for the group of `containerIds`. We should use `hashset` consistently. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51668/#review147941 ----------------------------------------------------------- On Sept. 12, 2016, 11:42 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51668/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 11:42 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Changed the nested ContainerID from hashmap to list in memory. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 078ef4f4e7bf5e1522804a720c51cfa5518d8efd > > Diff: https://reviews.apache.org/r/51668/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
