> On Sept. 25, 2016, 10:27 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.hpp, line 340 > > <https://reviews.apache.org/r/51668/diff/3/?file=1509664#file1509664line340> > > > > Should we change 'containers' to 'children'? You can do that in a > > followup patch.
Thought 'children' more appropriate previously. I will post a followup patch. Thanks! - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51668/#review150340 ----------------------------------------------------------- On Sept. 24, 2016, 11:50 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51668/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2016, 11:50 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > To support nested containers, each container should maintain a list > of its children containers in structure. The tree-like structure is > not necessary though. We just need to keep a flat hashset for nested > containers. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 16f9e3e92e90fe7f8a0ebd24e567800e1f285bc9 > > Diff: https://reviews.apache.org/r/51668/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
