----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51835/#review148657 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 425) <https://reviews.apache.org/r/51835/#comment216162> user may be None here and `user.get()` below would return error? - haosdent huang On Sept. 13, 2016, 4:59 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51835/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2016, 4:59 a.m.) > > > Review request for mesos, haosdent huang and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > For command tasks that have rootfs defined, the command executor will > be running as root. However, the task might want to manipulate > cgroups. This patch allows that. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 8b6dfde366caf82d30afb891c8f1337ceed12157 > > Diff: https://reviews.apache.org/r/51835/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
