----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51904/#review149143 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.cpp (line 6579) <https://reviews.apache.org/r/51904/#comment216662> reword the comment. src/slave/slave.cpp (line 6592) <https://reviews.apache.org/r/51904/#comment216661> ``` if (!terminal) ``` src/tests/slave_tests.cpp (line 4860) <https://reviews.apache.org/r/51904/#comment216663> Kill a task in the task group - Vinod Kone On Sept. 15, 2016, 4:34 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51904/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2016, 4:34 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6154 > https://issues.apache.org/jira/browse/MESOS-6154 > > > Repository: mesos > > > Description > ------- > > Previously, we were not correctly sending TASK_KILLED status updates > for a queued task group if some/all of its tasks were killed before > launch on the agent. Also, we would have still sent the killed task > group erroneously to the executor upon subscribing with the agent > even if it was killed. > > > Diffs > ----- > > src/slave/slave.cpp 863ab9d9c9332ac618fd102c096c7aa39343c0fe > src/tests/slave_tests.cpp e8b7dc0c1daf11aaf5e917e3a20897712c2983b6 > > Diff: https://reviews.apache.org/r/51904/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
