> On Sept. 20, 2016, 9:34 p.m., Jiang Yan Xu wrote: > > Given these comments, do you want to punt on improving the simple string > > parsing and get the JSON format working first? > > > > Also we should have independent unit tests here in resources_tests.cpp, > > this shouldn't to be coupled with the containerizer.
Ok. I will close this one for now. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/#review149710 ----------------------------------------------------------- On Sept. 19, 2016, 10:43 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52001/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2016, 10:43 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6062 > https://issues.apache.org/jira/browse/MESOS-6062 > > > Repository: mesos > > > Description > ------- > > Text based representation of disk resources can indicate source type > (ie. PATH or MOUNT) and its root. This makes it closer to the JSON > representation. > > > Diffs > ----- > > src/common/resources.cpp 4602bff22ec7ff77f069056085ad92bfa04595f3 > src/v1/resources.cpp 7c4db44d4c31a8295cc16b0ce1ef5adf314e6ac6 > > Diff: https://reviews.apache.org/r/52001/diff/ > > > Testing > ------- > > > Thanks, > > Anindya Sinha > >