----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/#review149433 -----------------------------------------------------------
Ditto for v1 src/common/resources.cpp (line 610) <https://reviews.apache.org/r/52001/#comment217061> s/pair/tokens pair is not good here, I intend to understand it has two values. src/common/resources.cpp (line 611) <https://reviews.apache.org/r/52001/#comment217074> A unit test is needed to test the case when token size is 3 src/common/resources.cpp (lines 626 - 627) <https://reviews.apache.org/r/52001/#comment217071> new line here src/common/resources.cpp (line 632) <https://reviews.apache.org/r/52001/#comment217072> What about print out the `key` but not `token` here as the `key` might be more accurate. src/common/resources.cpp (line 642) <https://reviews.apache.org/r/52001/#comment217073> How about s/token/diskTypeRoot src/common/resources.cpp (lines 682 - 683) <https://reviews.apache.org/r/52001/#comment217068> new line here src/common/resources.cpp (lines 687 - 688) <https://reviews.apache.org/r/52001/#comment217069> new line here - Guangya Liu On 九月 19, 2016, 5:01 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52001/ > ----------------------------------------------------------- > > (Updated 九月 19, 2016, 5:01 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6062 > https://issues.apache.org/jira/browse/MESOS-6062 > > > Repository: mesos > > > Description > ------- > > Text based representation of disk resources can indicate source type > (ie. PATH or MOUNT) and its root. This makes it closer to the JSON > representation. > > > Diffs > ----- > > src/common/resources.cpp 4602bff22ec7ff77f069056085ad92bfa04595f3 > src/v1/resources.cpp 7c4db44d4c31a8295cc16b0ce1ef5adf314e6ac6 > > Diff: https://reviews.apache.org/r/52001/diff/ > > > Testing > ------- > > > Thanks, > > Anindya Sinha > >
