----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/#review149913 -----------------------------------------------------------
Ship it! Ship It! - Greg Mann On July 29, 2016, 11:56 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40410/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 11:56 p.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, > and Vinod Kone. > > > Bugs: MESOS-3934 > https://issues.apache.org/jira/browse/MESOS-3934 > > > Repository: mesos > > > Description > ------- > > The metrics singleton must be unified with `process::initialize` so > that it also falls under the scope of reinitialization. The singleton > must also not be guarded by `Once`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/metrics.hpp > 54487ab2614c7f8e8df10d1e0c39880a6cf5bde3 > 3rdparty/libprocess/src/metrics/metrics.cpp > ac1544e70f5884f946ce3c31c5430c6a2c1f9dd1 > 3rdparty/libprocess/src/process.cpp > 7f331b812de2f0437838f48e0959441c8e04c358 > 3rdparty/libprocess/src/tests/system_tests.cpp > 0f4d0424689522337806ba2227ec4330c700e17e > > Diff: https://reviews.apache.org/r/40410/diff/ > > > Testing > ------- > > Tests done in a subsequent review. > > > Thanks, > > Joseph Wu > >
